Fix sidebar agent click zones mapping all lines to first agent#2402
Merged
trungutt merged 1 commit intodocker:mainfrom Apr 13, 2026
Merged
Conversation
buildAgentClickZones used lipgloss.Width()==0 to detect blank separator lines between agent blocks, but TabStyle.Width() pads all lines with whitespace, so separator lines had non-zero width. This caused every agent line to be mapped to the first agent, making clicking on any agent other than the first one impossible. Replace the check with isVisuallyBlank() which strips ANSI codes and checks for whitespace-only content. Add regression test. Assisted-By: docker-agent
trungutt
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Clicking on an agent in the sidebar always switched to the first agent, regardless of which agent was clicked.
Root Cause
buildAgentClickZonesusedlipgloss.Width(lines[i]) == 0to detect blank separator lines between agent blocks. However,TabStyle.Width()pads all lines with whitespace, so separator lines had non-zero width. This caused every agent line to be mapped to the first agent.Fix
Replace the width check with
isVisuallyBlank(), which strips ANSI escape codes and checks for whitespace-only content. Added a regression test that verifies clicking on each agent in a multi-agent sidebar correctly identifies the right agent.