Skip to content

update PR review workflow with fork-supporting trigger#2596

Merged
derekmisler merged 1 commit intodocker:mainfrom
derekmisler:update-pr-review-workflow-with-fork-supporting-tri
Apr 29, 2026
Merged

update PR review workflow with fork-supporting trigger#2596
derekmisler merged 1 commit intodocker:mainfrom
derekmisler:update-pr-review-workflow-with-fork-supporting-tri

Conversation

@derekmisler
Copy link
Copy Markdown
Contributor

@derekmisler derekmisler commented Apr 29, 2026

Summary

Refactor PR review workflow to use a fork-supporting trigger pattern. This decouples the review job from direct event triggers and uses artifact passing to support fork PRs, which cannot access secrets in the main workflow.

Closes: https://github.com/docker/gordon/issues/468

Changes

  • New workflow: pr-review-trigger.yml captures PR and review comment events, saves context (event name, PR number, SHA, comment JSON) as artifacts
  • Updated workflow: pr-review.yml now uses workflow_run trigger to run after the trigger workflow completes, downloads artifacts to access saved context
  • Permissions: Added actions: read to allow artifact downloads; simplified permission comments
  • Version bump: Updated cagent-action from v1.4.1 to v1.4.3
  • New input: Added trigger-run-id parameter to pass workflow run ID from trigger workflow

Test plan

  • Verify PR review triggers on /review command in PR comments
  • Verify auto-review triggers on PR open/ready_for_review (same-repo branches)
  • Verify fork PRs can trigger review via /review command (previously blocked by secret access)
  • Confirm review comments on review feedback still trigger review

Signed-off-by: Derek Misler <derek.misler@docker.com>
@derekmisler derekmisler self-assigned this Apr 29, 2026
@derekmisler derekmisler requested a review from a team April 29, 2026 14:18
@derekmisler derekmisler marked this pull request as ready for review April 29, 2026 14:18
@derekmisler derekmisler merged commit 31712ae into docker:main Apr 29, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants