Skip to content

Avoid init functions #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgageot merged 1 commit into from
Sep 22, 2025
Merged

Avoid init functions #262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/telemetry/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ func NewClient(logger *slog.Logger, enabled, debugMode bool, version string, cus

client := &Client{
logger: telemetryLogger,
userUUID: getUserUUID(),
enabled: enabled,
debugMode: debugMode,
httpClient: httpClient,
Expand Down
2 changes: 1 addition & 1 deletion pkg/telemetry/http.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ func (tc *Client) createEvent(eventName string, properties map[string]any) Event
}

// Add system metadata to properties
allProperties["user_uuid"] = userUUID
allProperties["user_uuid"] = tc.userUUID
allProperties["version"] = tc.version
allProperties["os"] = osInfo
allProperties["os_language"] = osLanguage
Expand Down
1 change: 1 addition & 0 deletions pkg/telemetry/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,7 @@ type HTTPClient interface {
// Client provides simplified telemetry functionality for cagent
type Client struct {
logger *telemetryLogger
userUUID string
enabled bool
debugMode bool // Print to stdout instead of sending
httpClient HTTPClient
Expand Down
7 changes: 0 additions & 7 deletions pkg/telemetry/utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ import (
"github.com/spf13/cobra"
)

var userUUID string

// Build-time telemetry configuration (set via -ldflags)
var (
TelemetryEnabled = "true" // Default enabled
Expand Down Expand Up @@ -183,8 +181,3 @@ func BuildCommandInfo(cmd *cobra.Command, args []string, baseName string) Comman

return info
}

// init generates UUIDs once per process
func init() {
userUUID = getUserUUID()
}