Skip to content

fix(shell): do not enforce "assisted-by" by default.#2671

Merged
dgageot merged 1 commit intodocker:mainfrom
maxcleme:patch-1
May 6, 2026
Merged

fix(shell): do not enforce "assisted-by" by default.#2671
dgageot merged 1 commit intodocker:mainfrom
maxcleme:patch-1

Conversation

@maxcleme
Copy link
Copy Markdown
Member

@maxcleme maxcleme commented May 6, 2026

No description provided.

@maxcleme maxcleme requested a review from a team as a code owner May 6, 2026 15:04
Copy link
Copy Markdown
Member

@rumpl rumpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

boo

Copy link
Copy Markdown

@docker-agent docker-agent Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟢 APPROVE

The change removes the instruction recommending the Assisted-By: docker-agent git commit trailer from the shell tool's Instructions() method. This is a one-line documentation-only removal with no logic changes, no new code paths, and no risk of introducing bugs. The change correctly aligns the runtime instructions with the PR's stated intent — not enforcing the trailer by default.

No issues found.

@dgageot dgageot merged commit 54652c5 into docker:main May 6, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants