set working dir properly#2777
Merged
krissetto merged 1 commit intoMay 13, 2026
Merged
Conversation
Signed-off-by: Christopher Petito <chrisjpetito@gmail.com>
rumpl
approved these changes
May 13, 2026
docker-agent
left a comment
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
The fix is correct and well-targeted. runtime.WithWorkingDir(runConfig.WorkingDir) was missing from the runtimeOpts call, meaning all new TUI sessions inherited a stale or empty working directory. The one-line addition restores the intended behavior.
The new test (TestRuntimeOptsPassesRunConfigWorkingDirToRuntime) exercises the happy path end-to-end and gives good regression coverage for the fix.
No bugs were found in the changed code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when opening a new tab in a new working dir in the TUI, i noticed my agents freaking out and doing weird stuff in the wrong directories, only to find out they we're getting the wrong working dir in their environment info
this must've gotten lost during some refactor, idk