feat: add timeout and allow_private_ips support to api and openapi tools#2865
Merged
dgageot merged 2 commits intoMay 21, 2026
Merged
Conversation
- Refresh Toolset.Timeout and Toolset.AllowPrivateIPs doc comments to reflect api and openapi builtin tools. - Replace hard-coded timeout with defaultHTTPTimeout const in api tool. - Rename unused parameter in timeout test handler. - Clarify private-IP opt-in propagation in openapi test comment.
|
❌ PR Review Failed — The review agent encountered an error and could not complete the review. View logs. |
rumpl
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
timeoutandallow_private_ipsconfiguration options were previously only available on thefetchbuiltin tool. This change extends both options to theapiandopenapibuiltin toolsets, bringing consistency across HTTP-based tools.Both toolsets now respect the configured timeout value (defaulting to 30 seconds) and honor the
allow_private_ipsopt-in to dial non-public IP addresses. Validation logic and schema have been updated to reflect the expanded scope of these options.The branch also includes minor doc clarifications and code cleanups to make the implementation consistent with existing patterns.