Rename OAuth elicitation meta keys from cagent/ to docker-agent/#2915
Merged
Conversation
The OAuth elicitation Meta map keys still carry the legacy product name (cagent/type, cagent/server_url). The runtime was renamed to docker-agent some time ago; align the meta keys with it so the contract clients see matches the project name they're integrating against. Renamed: cagent/type -> docker-agent/type cagent/server_url -> docker-agent/server_url Both writer sites (handleManagedOAuthFlow, handleUnmanagedOAuthFlow) and every in-tree reader (CLI runner, RemoteRuntime OAuth mirror, TUI elicitation handling) are updated together. Out-of-tree consumers will need the same one-line rename. Other cagent/* identifiers that are NOT in the elicitation Meta map (user-config paths under ~/.cagent/, the User-Agent header, the cagent/title meta key used by the user_prompt builtin) are intentionally left alone -- the rename is scoped to OAuth meta. Signed-off-by: Trung Nguyen <trung.nguyen@docker.com>
trungutt
force-pushed
the
rename-oauth-meta-keys
branch
from
f539e73 to
dfca23c
Compare
aheritier
added
area/mcp
|
❌ PR Review Failed — The review agent encountered an error and could not complete the review. View logs. |
dgageot
approved these changes
May 28, 2026
This was referenced May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The OAuth elicitation
Metamap keys still carry the legacy product name (cagent/type,cagent/server_url). The runtime was renamed todocker-agentsome time ago; align the meta keys with it so the contract clients see matches the project name they're integrating against.Renamed:
cagent/typedocker-agent/typecagent/server_urldocker-agent/server_urlBoth writer sites (
handleManagedOAuthFlow,handleUnmanagedOAuthFlow) and every in-tree reader (CLI runner,RemoteRuntimeOAuth mirror, TUI elicitation handling) are updated together.