chore(config): freeze v9 and bump latest to v10#2960
Merged
Conversation
docker-agent
reviewed
Jun 2, 2026
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This PR correctly implements the v9 freeze and v10 bump pattern. The version upgrade chain has been reviewed end-to-end:
pkg/config/v9/types.godeclaresVersion = "9"✅pkg/config/v9/parse.goimportsv8aspreviousand upgradesv8.Config → v9.Config✅pkg/config/latest/types.godeclaresVersion = "10"✅pkg/config/latest/parse.goimportsv9aspreviousfor thev9.Config → v10.Configstep ✅pkg/config/versions.goinsertsv9.Register(...)betweenv8andlatestin the upgrade chain ✅agent-schema.jsondescription updated to v10 ✅
No bugs found in the added code. The pkg/config/v9/ package is a correct frozen snapshot with all files declaring package v9, proper import paths, and no stale references to the old latest package.
Assisted-By: docker-agent
006a7b2 to
80ac8ba
Compare
trungutt
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The configuration schema evolves incrementally as new features are added. To support this safely, we freeze completed schema versions as immutable numbered packages and continue development on
latest.This change creates
pkg/config/v9as a frozen copy of the previouslatestpackage and bumpslatestto represent the work-in-progress v10 schema. The upgrade path inpkg/config/versions.gois updated so that v9 configs upgrade through v9's parser before reaching v10.No behavior changes for existing configurations.