Skip to content

chore(config): freeze v9 and bump latest to v10#2960

Merged
trungutt merged 1 commit into
docker:mainfrom
dgageot:board/f0cc00477687fe07
Jun 2, 2026
Merged

chore(config): freeze v9 and bump latest to v10#2960
trungutt merged 1 commit into
docker:mainfrom
dgageot:board/f0cc00477687fe07

Conversation

@dgageot
Copy link
Copy Markdown
Member

@dgageot dgageot commented Jun 2, 2026

The configuration schema evolves incrementally as new features are added. To support this safely, we freeze completed schema versions as immutable numbered packages and continue development on latest.

This change creates pkg/config/v9 as a frozen copy of the previous latest package and bumps latest to represent the work-in-progress v10 schema. The upgrade path in pkg/config/versions.go is updated so that v9 configs upgrade through v9's parser before reaching v10.

No behavior changes for existing configurations.

@dgageot dgageot requested a review from a team as a code owner June 2, 2026 06:38
Copy link
Copy Markdown

@docker-agent docker-agent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟢 APPROVE

This PR correctly implements the v9 freeze and v10 bump pattern. The version upgrade chain has been reviewed end-to-end:

  • pkg/config/v9/types.go declares Version = "9"
  • pkg/config/v9/parse.go imports v8 as previous and upgrades v8.Config → v9.Config
  • pkg/config/latest/types.go declares Version = "10"
  • pkg/config/latest/parse.go imports v9 as previous for the v9.Config → v10.Config step ✅
  • pkg/config/versions.go inserts v9.Register(...) between v8 and latest in the upgrade chain ✅
  • agent-schema.json description updated to v10 ✅

No bugs found in the added code. The pkg/config/v9/ package is a correct frozen snapshot with all files declaring package v9, proper import paths, and no stale references to the old latest package.

Assisted-By: docker-agent
@dgageot dgageot force-pushed the board/f0cc00477687fe07 branch from 006a7b2 to 80ac8ba Compare June 2, 2026 07:26
@trungutt trungutt merged commit 350b6ac into docker:main Jun 2, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants