fix: cycle thinking level in lean tui#3246
Merged
Merged
Conversation
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
Reviewed pkg/leantui/update.go and pkg/leantui/update_test.go.
The Shift+Tab → handleCycleThinkingLevel implementation is correct:
- Nil guard on
m.appprevents panics before any app is attached. SupportsModelSwitchingguard correctly surfaces a user-friendly notice for remote runtimes before attempting the cycle.- Error branching handles both
runtime.ErrUnsupported(model-specific, shown as muted notice) and generic errors (shown with error styling) without updatingm.status.thinkingon failure — correct behaviour. - Status + notice update on success is appropriately minimal; the synchronous write to
m.status.thinkingfollowed by the asyncTeamInfoEventfromrefreshAgentInfois safe because both writes land on the lean TUI's single event-loop goroutine via theselectinleantui.go. - Tests cover the success path and the
ErrUnsupportedpath with a well-structured mock.
No bugs found in the changed code.
2e43bf9 to
0b2e6b1
Compare
0b2e6b1 to
1317ada
Compare
dgageot
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
go test ./pkg/leantuigo test ./pkg/app ./pkg/tui ./pkg/leantuigo vet ./pkg/leantuigo build ./...Note:
task lintcould not be run becausetaskis not installed in this environment.go test ./...was attempted and hit unrelated existing/environmental failures inpkg/cacheandpkg/rag/treesitter(CGO_ENABLED=1required).