refactor(tui): remove redundant agent-switch and thinking-level toasts#3266
Merged
Merged
Conversation
Both actions already provide visual feedback elsewhere in the UI (the chat view reflects the active agent, and the sidebar shows the current thinking-effort level), so the success toasts were redundant noise.
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
Clean refactor that removes two redundant toast notifications. Both and correctly preserve their error paths, state mutations, and return semantics. The simplification in and the in are both valid Bubble Tea patterns with no behavioral regression.
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
Clean refactor that removes two redundant toast notifications. Both handleSwitchAgent and handleCycleThinkingLevel correctly preserve their error paths, state mutations, and return semantics. The tea.Batch simplification in handleSwitchAgent and the return m, nil in handleCycleThinkingLevel are both valid Bubble Tea patterns with no behavioral regression.
aheritier
added
area/tui
aheritier
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two toast notifications in the TUI were firing on actions whose result is already visible in the interface without them. The "Switched to agent" success toast appeared every time the user switched the active agent, even though the chat view header immediately reflects the new agent. The "✻ Thinking: low" info toast appeared on every thinking-level cycle, even though the sidebar already shows the current effort level. Neither notification added information the user couldn't already see.
Both toasts have been removed from
handleSwitchAgentandhandleCycleThinkingLevelinpkg/tui/handlers.go. All other behavior is unchanged: the underlying state mutations, keybindings, and visual indicators in the chat and sidebar remain exactly as before.No breaking changes. The only observable difference is the absence of those two transient pop-ups.