feat: reuse warmed model store, add picker timing, and fix discovery error caching#3285
Merged
Merged
Conversation
Log durations at each stage of model discovery, filtering, and rendering to help diagnose model picker latency. Assisted-By: claude-opus-4-5
aheritier
approved these changes
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The model picker pipeline was doing redundant work: each runtime session, server session, and embedded-chat path independently warmed its own models.dev store, even though a single warm copy is sufficient for the lifetime of the process. On top of that, context-cancelled discovery errors were being cached, causing subsequent requests to fail silently, and the picker had no way to understand why discovery was slow or where time was being spent.
This change wires a single shared
ModelStorethrough the CLI entry point (cmd/root/run.go), the app layer, and both the runtime and server session constructors, so the expensive initial fetch happens once and the result is reused everywhere. The model picker now also accepts custom provider references directly, lifting a restriction that forced all providers through the standard discovery path. Timing instrumentation has been added throughout the picker pipeline — from initial store lookup through to final model selection — so latency spikes are visible in debug logs. Finally, context-cancellation errors are no longer cached in the discovery layer; a cancelled lookup leaves the cache empty so the next request retries cleanly.Validated with
task --force lintandtask --force test.