fix: support steering in lean TUI#3474
Merged
Merged
Conversation
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
docker-agent
reviewed
Jul 4, 2026
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
The steering queue routing, pending-message reconciliation, and deduplication logic introduced in this PR are all correct.
Key paths reviewed:
dispatchUserMessagecorrectly routesbusySubmitSteerviaapp.Steerand records a pending entry withdisplay/contentfields.handleUserMessageEventcorrectly consumes the pending entry by matching oncontent(notdisplay), so the user-facing display text (e.g./change) is preserved when echoing while the resolved content is used for matching.samePendingUserContentcorrectly handles the trailing\nthat the runtime appends to emitted messages viastrings.TrimSuffix, so reconciliation succeeds reliably.finishBusycorrectly dequeues follow-up messages and promotes their pending display text before echoing.- Error from
app.Steeris surfaced to the user via a notice; no silent failure.
No bugs found in the changed code.
dgageot
approved these changes
Jul 4, 2026
Piyush0049
pushed a commit
to Piyush0049/docker-agent
that referenced
this pull request
Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests