feat: Implement stack-based multiple dialogs management in TUI#355
Merged
rumpl merged 1 commit intodocker:mainfrom Oct 1, 2025
Merged
feat: Implement stack-based multiple dialogs management in TUI#355rumpl merged 1 commit intodocker:mainfrom
rumpl merged 1 commit intodocker:mainfrom
Conversation
rumpl
force-pushed
the
feature/multiple-dialogs-management
branch
5 times, most recently
from
efa5dfe to
3e49ada
Compare
- Replace single dialog with LIFO stack for managing multiple overlapping dialogs - Add GetLayers() method to return all dialog layers for proper rendering - Add DialogCount() method to query number of active dialogs - Implement CloseAllDialogsMsg for clearing entire dialog stack - Update message routing: only topmost dialog receives input events - Propagate window resize events to all dialogs in stack - Add comprehensive test suite with 5 test cases covering all operations - Maintain full backward compatibility with existing dialog usage This enables nested dialogs and multi-step workflows in the TUI, with proper modal behavior and automatic resource management. Co-authored-by: cagent <cagent@docker.com> Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
rumpl
force-pushed
the
feature/multiple-dialogs-management
branch
from
3e49ada to
8ac3132
Compare
krissetto
approved these changes
Oct 1, 2025
Contributor
krissetto
left a comment
krissetto
left a comment
There was a problem hiding this comment.
Noice. The tests mentioned in the pr description aren't there though, is that intentional?
Member
Author
Fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a stack-based dialog management system that supports multiple overlapping dialogs in the TUI.