Skip to content

redirectURI should have been in runtimeConfig #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krissetto merged 1 commit into from
Oct 1, 2025
Merged

redirectURI should have been in runtimeConfig #375

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions cmd/root/api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,9 @@ import (
)

var (
listenAddr string
sessionDb string
redirectURI string
runConfig config.RuntimeConfig
listenAddr string
sessionDb string
runConfig config.RuntimeConfig
)

// NewApiCmd creates a new api command
Expand All @@ -39,7 +38,7 @@ func NewApiCmd() *cobra.Command {
cmd.PersistentFlags().StringVarP(&sessionDb, "session-db", "s", "session.db", "Path to the session database")
cmd.PersistentFlags().StringSliceVar(&runConfig.EnvFiles, "env-from-file", nil, "Set environment variables from file")
cmd.PersistentFlags().BoolVar(&runConfig.GlobalCodeMode, "code-mode-tools", false, "Provide a single tool to call other tools via Javascript")
cmd.PersistentFlags().StringVar(&redirectURI, "redirect-uri", "", "Set the redirect URI for OAuth2 flows")
cmd.PersistentFlags().StringVar(&runConfig.RedirectURI, "redirect-uri", "", "Set the redirect URI for OAuth2 flows")
addGatewayFlags(cmd)

return cmd
Expand Down Expand Up @@ -93,7 +92,6 @@ func runHttp(cmd *cobra.Command, args []string) error {
}
}()

runConfig.RedirectURI = redirectURI
s := server.New(sessionStore, runConfig, teams, opts...)
return s.Serve(ctx, ln)
}
Loading