Start to use recent fs APIs to restrict which directory we have access to#423
Merged
dgageot merged 2 commits intodocker:mainfrom Oct 6, 2025
Merged
Start to use recent fs APIs to restrict which directory we have access to#423dgageot merged 2 commits intodocker:mainfrom
dgageot merged 2 commits intodocker:mainfrom
Conversation
rumpl
reviewed
Oct 6, 2025
Signed-off-by: David Gageot <david.gageot@docker.com>
krissetto
approved these changes
Oct 6, 2025
.vscode/mcp.json
Outdated
Contributor
There was a problem hiding this comment.
not needed? we could add .vscode to the gitignore
Member
Author
There was a problem hiding this comment.
Good catch! I opened another PR
|
|
||
| // Load the agent's configuration | ||
| cfg, err := config.LoadConfigSecure(fileName, parentDir) | ||
| cfg, err := config.LoadConfigSecureDeprecated(fileName, parentDir) |
Contributor
There was a problem hiding this comment.
are these uses of LoadConfigSecureDeprecated also meant to be eventually updated?
Signed-off-by: David Gageot <david.gageot@docker.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.