Fix shell process cleanup#564
Merged
rumpl merged 2 commits intodocker:mainfrom Oct 24, 2025
Merged
Conversation
rumpl
added
the
area/tools
This was referenced Oct 21, 2025
Closed
This reverts commit 832479e.
rumpl
force-pushed
the
fix-shell
branch
2 times, most recently
from
ab2833a to
5f50c1d
Compare
Terminating the command executed and all of its children too Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
trungutt
approved these changes
Oct 24, 2025
Contributor
trungutt
left a comment
trungutt
left a comment
There was a problem hiding this comment.
That works for Mac, when stop the stream, it also stops the child process
Contributor
|
But it still doesn't handle cleanly long-running process yet |
Member
Author
|
If the LLM starts a Background tools will come later if needed |
krissetto
approved these changes
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of using
exec.CommandContextand keeping the process handlers in the tool, select either the tool completion or the context cancellation, in the case a cancelled context, terminate the whole process group.Draft for now, need to do it for windows too.
Fixes #562 (once I'm done)