Skip to content

Don't cache messages #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgageot merged 2 commits into from
Oct 23, 2025
Merged

Don't cache messages #592

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d455fb6
Don't cache messages
rumpl Oct 23, 2025
f5f02ea
Remove the start field from the renderedItem
rumpl Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions pkg/tui/components/messages/messages.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ type renderedItem struct {
id int // Message ID or index as int
view string // Cached rendered content
height int // Height in lines
start int // Starting line position in complete content
end int // Ending line position in complete content
}

Expand Down Expand Up @@ -351,7 +350,6 @@ func (m *model) ensureAllItemsRendered() {
item := m.renderItem(i, view)

// Update position information
item.start = currentPosition
if item.height > 0 {
item.end = currentPosition + item.height - 1
} else {
Expand All @@ -370,9 +368,6 @@ func (m *model) ensureAllItemsRendered() {
allLines = append(allLines, "")
currentPosition += 1
}

// Update cache with position information
m.renderedItems[i] = item
}

m.rendered = strings.Join(allLines, "\n")
Expand Down
Loading