Auto-pull DMR models#602
Merged
dgageot merged 1 commit intodocker:mainfrom Oct 29, 2025
Merged
Conversation
9140157 to
d1e6b74
Compare
rumpl
reviewed
Oct 24, 2025
| } | ||
|
|
||
| func modelExists(ctx context.Context, model string) bool { | ||
| cmd := exec.CommandContext(ctx, "docker", "model", "inspect", model) |
Member
Author
There was a problem hiding this comment.
I didn't want to go that route... But I might have because it also needs to detect if the platform supports DMR at all.
Member
Author
|
@krissetto do you know what's the cleanest way to detect that DMR is not supported and therefore not trigger the auto-pull? |
d1e6b74 to
84aa700
Compare
Signed-off-by: David Gageot <david.gageot@docker.com>
84aa700 to
7986fb5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.