Fix the mouse position on selection#733
Merged
dgageot merged 1 commit intodocker:mainfrom Nov 5, 2025
Merged
Conversation
We used to have a title bar, but that changed and we now either only have a sidebar or the sidebar becomes the title bar depending on the window size. This means that the position of the messages component is not static any more so mouse events became wrong in certain cases (when there is no title bar). This fixes it by sending the messages component its absolute position on the screen when needed. Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
dgageot
approved these changes
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used to have a title bar, but that changed and we now either only have a sidebar or the sidebar becomes the title bar depending on the window size. This means that the position of the messages component is not static any more so mouse events became wrong in certain cases (when there is no title bar). This fixes it by sending the messages component its absolute position on the screen when needed.