Add support for codex#854
Merged
dgageot merged 1 commit intodocker:mainfrom Nov 20, 2025
Merged
Conversation
Member
Author
|
A list of models that DON'T support responses: And those that DO: |
Member
Author
|
We could use the response API for everything that doesn't contain: |
dgageot
force-pushed
the
codex
branch
2 times, most recently
from
33a523d to
e27f8ef
Compare
Member
Author
|
@rumpl I'll activate it only for codex at first so that we can merge it and test more. wdyt? |
Member
|
For sure! |
Let's not use this API for other models for now. We need some more battle testing Signed-off-by: David Gageot <david.gageot@docker.com>
rumpl
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly vibe coded, with gemini 3 pro and sonnet 4.5, with no verification of the code so far.
I tested a few commands like:
and
no tool call yet