Fix session creation when using ociRefs and passing a working_dir#914
Merged
krissetto merged 1 commit intodocker:mainfrom Nov 24, 2025
Merged
Conversation
krissetto
added
kind/bug
…ing a working_dir in the sess creation request Signed-off-by: Christopher Petito <chrisjpetito@gmail.com>
krissetto
force-pushed
the
fix-working-dir-sessions-with-ociref
branch
from
7ccc0ae to
c8bc287
Compare
trungutt
approved these changes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we get a new session creation request and
cagent apiis running with an OCI reference, we need to make sure we re-create the team from the OCI reference if we get a working directory in the session creation request so things reference the correct working dir.Fixes https://github.com/docker/ai/issues/188