feat: dynamic newline shortcuts based on terminal capabilities#930
Merged
rumpl merged 2 commits intodocker:mainfrom Nov 25, 2025
Merged
feat: dynamic newline shortcuts based on terminal capabilities#930rumpl merged 2 commits intodocker:mainfrom
rumpl merged 2 commits intodocker:mainfrom
Conversation
Member
|
cc @rumpl |
rumpl
approved these changes
Nov 25, 2025
Member
|
Tested, works, thanks <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #871
Tested on iTerm, Ghostty, and default Mac Terminal to verify the behavior across different terminal capabilities.
Hey @rumpl, I have some thoughts regarding the implementation after working on this issue. I've implemented keyboard enhancement detection as suggested, listening to
tea.KeyboardEnhancementsMsg, checkingmsg.Flags, and dynamically configuring shortcuts.However, during implementation I discovered a terminal protocol limitation: even with keyboard enhancements enabled
(Flags != 0), terminals likeiTermsendshift+enterasctrl+jwithout preserving theshift modifier(debug shows: Key="ctrl+j", Mod=4 (ModCtrl), ShiftMod=false), making them indistinguishable at the protocol level. Given this reality, the implementation shows both"shift+enter / ctrl+j"in the status bar for modern terminals (since both work due to the protocol mapping) and only "ctrl+j" for legacy terminals.This approach matches what Claude Code, Gemini, and other modern terminal applications do, they acknowledge both shortcuts work in enhanced terminals rather than artificially restricting to one when the terminal protocol
doesn't allow true separation.