Skip to content

Add pull option for container create and run#3406

Open
zainnadeem786 wants to merge 1 commit into
docker:mainfrom
zainnadeem786:fix-container-pull-kwarg
Open

Add pull option for container create and run#3406
zainnadeem786 wants to merge 1 commit into
docker:mainfrom
zainnadeem786:fix-container-pull-kwarg

Conversation

@zainnadeem786
Copy link
Copy Markdown

Summary

Adds support for passing the pull option when creating or running containers.

This change:

  • Adds pull as a create-level kwarg
  • Passes pull through to the container create API query params
  • Preserves existing automatic image pull fallback behavior
  • Avoids fallback pulling when pull="never" is used

Fixes #3369

Tests

Passed:

  • tests/unit/api_container_test.py::CreateContainerTest::test_create_container_with_pull
  • Relevant new pull-related tests

Broader local test runs had unrelated environment-sensitive failures involving timezone offsets, Docker context/configuration, and local TLS settings.

Signed-off-by: zainnadeem(RedOpsCell) <zainnadeemzainnadeem80@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add pull to the list of kwargs to pass to create and run

1 participant