Pull: only close temporary file once#21676
Merged
vdemeester merged 1 commit intomoby:masterfrom Mar 31, 2016
Merged
Conversation
Member
There was a problem hiding this comment.
You probably shouldn't return nil here?
aaronlehmann
force-pushed
the
tmpfile-close
branch
from
3ed2f1d to
0ad5583
Compare
Close could be called twice on a temporary download file, which could have bad side effects. This fixes the problem by setting to ld.tmpFile to nil when the download completes sucessfully. Then the call to ld.Close will have no effect, and only the download manager will close the temporary file when it's done extracting the layer from it. ld.Close will be responsible for closing the file if we hit the retry limit and there is still a partial download present. Fixes moby#21675 Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
aaronlehmann
force-pushed
the
tmpfile-close
branch
from
0ad5583 to
930ae3d
Compare
Member
|
LGTM |
Member
|
LGTM 🐧 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the problem by setting to ld.tmpFile to nil when the download
completes sucessfully. Then the call to ld.Close will have no effect,
and only the download manager will close the temporary file when it's
done extracting the layer from it. ld.Close will be responsible for
closing the file if we hit the retry limit and there is still a partial
download present.
Fixes #21675