Feedback for: engine/getstarted-voting-app/customize-app.md

[karptonite]

File: engine/getstarted-voting-app/customize-app.md, CC: @mstanleyjones

It would be useful if, at the end of this tutorial, you included instructions on how to shut down the app gracefully, and remove what was installed.

[karptonite]

In particular, going through this tutorial sets env vars in such a way that you can no longer use Docker for Mac at the end, until you unset those variables. I figured that out pretty quick because I happened to have read the docs on that issue, but it might have been very annoying, otherwise.

[londoncalling]

@karptonite the Docker Machine environment variables that you set should not cause any problems with Docker for Mac. I've run this tutorial several times on Docker for Mac, and have no conflicts.

I can add a section about shutting down the app, which essentially involves shutting down the manager and worker machines you created, and if desired, removing the machines. That's a good idea.

Let me know what conflicts you ran into on Docker for Mac. You should just be able to open up new terminal windows, and continue working as before.

cc @ManoMarks in case you have further comments.

[karptonite]

The issue may have been that I continued to work in the same terminal window? I'll have to try again to confirm.

[ManoMarks]

I think it would be good to have a section on shutting down the app and the docker machine instances

[londoncalling]

@karptonite @ManoMarks

Per PR #1932 , I've added a new topic on stopping the machines and the app, rebooting, and cleaning up altogether by removing the machines.

I'll close this issue now, but feel free to re-open if needed to add more comments. @karptonite thanks for the feedback.

[docker-robott]

Closed issues are locked after 30 days of inactivity.
This helps our team focus on active issues.

If you have found a problem that seems similar to this, please open a new issue.

/lifecycle locked