Skip to content

Engine: reorganize install topic#10479

Merged
usha-mandya merged 3 commits intodocker:masterfrom
thaJeztah:reorganize_engine_section
Apr 6, 2020
Merged

Engine: reorganize install topic#10479
usha-mandya merged 3 commits intodocker:masterfrom
thaJeztah:reorganize_engine_section

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Mar 18, 2020

  • Move getting started overview to /get-started/overview/
  • Move engine installation files under /engine/
  • Redirect the top-level /install/ to /get-docker/
  • Updated titles in left-hand navigation
  • Added back some pages to the navigation that were currently not included.
  • Move /engine/docker-overview/ to /get-started/overview/
  • Reduce some steps in the installation pages
  • Move devicemapper prerequisites to the devicemapper storage driver page.
  • engine: remove overlap between "overview" and "install" page
  • engine: cleanup install page, add info about derivatives

rewrite the engine "overview" page

This page is currently not a good introduction to the engine, and overlaps with the "global" introduction to Docker / overview in the getting started: http://localhost:4000/engine/docker-overview/

This PR makes some changes to the page to reduce the overlap, but may still need some TLC

(note that that page's URL is currently under "engine" - probably will fix that in this PR as well, and move it to either /docker-overview/ or /get-started/overview/)

With this PR, the navigation looks like this:

Screenshot 2020-03-18 at 13 45 50

@thaJeztah thaJeztah added the area/engine Issue affects Docker engine/daemon label Mar 18, 2020
@thaJeztah thaJeztah force-pushed the reorganize_engine_section branch from 761054f to e51d09f Compare March 18, 2020 14:13
@usha-mandya usha-mandya self-requested a review March 18, 2020 23:13
@thaJeztah thaJeztah force-pushed the reorganize_engine_section branch 4 times, most recently from 2f3238d to 8e59149 Compare April 6, 2020 08:46
@thaJeztah thaJeztah marked this pull request as ready for review April 6, 2020 08:50
- Move getting started overview to /get-started/overview/
- Move engine installation files under /engine/
- Redirect the top-level /install/ to /get-docker/
- Updated titles in left-hand navigation
- Added back some pages to the navigation that were
  currently not included.
- Reduce some steps in the installation pages
- Move devicemapper prerequisites to the devicemapper
  storage driver page.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah force-pushed the reorganize_engine_section branch from 8e59149 to 426f539 Compare April 6, 2020 08:50
@thaJeztah
Copy link
Copy Markdown
Member Author

@usha-mandya updated this PR, this should be ready for review now

Comment thread engine/index.md Outdated
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah force-pushed the reorganize_engine_section branch from 426f539 to 569f448 Compare April 6, 2020 12:04
Copy link
Copy Markdown
Member

@usha-mandya usha-mandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @thaJeztah

@usha-mandya usha-mandya merged commit 80d9ada into docker:master Apr 6, 2020
@thaJeztah thaJeztah deleted the reorganize_engine_section branch April 6, 2020 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/engine Issue affects Docker engine/daemon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants