Skip to content

Conversation

@gsaraf
Copy link

@gsaraf gsaraf commented Oct 5, 2020

Proposed changes

While following the guide I noticed it was using old versions of Ruby and Rails. So updating :)

Rails 6 requires Yarn, the source of which needs to be added to apt. See installation instructions https://classic.yarnpkg.com/en/docs/install/#debian-stable

Tested by following instructions and getting to working Rails setup.

Unreleased project version (optional)

None :)

Related issues (optional)

None :)

Rails 6 requires Yarn, the source of which needs to be added to apt. See installation instructions https://classic.yarnpkg.com/en/docs/install/#debian-stable

Tested by following instructions and getting to working Rails setup.
@netlify
Copy link

netlify bot commented Oct 5, 2020

Deploy preview for docsdocker ready!

Built with commit 971f7f4

https://deploy-preview-11476--docsdocker.netlify.app

@gsaraf
Copy link
Author

gsaraf commented Oct 26, 2020

Hi! Some time has passed - what should I do to get this reviewed?

Not super critical, just a small addition that will make it easier for future people :)

@JJ
Copy link
Contributor

JJ commented Dec 21, 2020

There's apparently a conflict now...

@gsaraf
Copy link
Author

gsaraf commented Jan 30, 2021

@JJ - Thanks, I've fixed the merge conflict.

@gsaraf
Copy link
Author

gsaraf commented May 6, 2021

Closing to clean up my queue.

@gsaraf gsaraf closed this May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants