Skip to content

Update changelogs for Docker Desktop edge 2.4.2.0 #11550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 19, 2020
Merged

Update changelogs for Docker Desktop edge 2.4.2.0 #11550

merged 3 commits into from
Oct 19, 2020

Conversation

@simonferquel
Copy link
Contributor

@simonferquel simonferquel commented Oct 15, 2020

Proposed changes

Update the changelog for Docker Desktop Edge 2.4.2.0

cc @stephen-turner @djs55 (far all grpc-fuse related things)

@netlify
Copy link

netlify bot commented Oct 15, 2020

Deploy preview for docsdocker ready!

Built with commit 977351e

https://deploy-preview-11550--docsdocker.netlify.app

@netlify
Copy link

netlify bot commented Oct 15, 2020 •
edited
Loading

Deploy preview for docsdocker ready!

Built with commit 92bcff6

https://deploy-preview-11550--docsdocker.netlify.app

stephen-turner
stephen-turner previously requested changes Oct 15, 2020
View reviewed changes
Copy link
Contributor

@stephen-turner stephen-turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a couple of small comments, but also @usha-mandya should advise on how to write the bug fix bullet points, I think they're not written in our standard format.

djs55
djs55 reviewed Oct 15, 2020
View reviewed changes
usha-mandya
usha-mandya reviewed Oct 15, 2020
View reviewed changes
usha-mandya
usha-mandya reviewed Oct 15, 2020
View reviewed changes
usha-mandya
usha-mandya reviewed Oct 15, 2020
View reviewed changes
usha-mandya
usha-mandya reviewed Oct 15, 2020
View reviewed changes
usha-mandya
usha-mandya reviewed Oct 15, 2020
View reviewed changes
usha-mandya
usha-mandya reviewed Oct 15, 2020
View reviewed changes
usha-mandya
usha-mandya reviewed Oct 15, 2020
View reviewed changes
usha-mandya
usha-mandya reviewed Oct 15, 2020
View reviewed changes
usha-mandya
usha-mandya reviewed Oct 15, 2020
View reviewed changes
usha-mandya
usha-mandya reviewed Oct 15, 2020
View reviewed changes
usha-mandya
usha-mandya reviewed Oct 15, 2020
View reviewed changes
@usha-mandya
Copy link
Member

usha-mandya commented Oct 15, 2020

I've made a couple of small comments, but also @usha-mandya should advise on how to write the bug fix bullet points, I think they're not written in our standard format.

Existing docs use '-' without any indentation for bulleted list, so I guess the current version looks good. I've added a screenshot for clarity.

image

@stephen-turner
Copy link
Contributor

stephen-turner commented Oct 15, 2020

I've made a couple of small comments, but also @usha-mandya should advise on how to write the bug fix bullet points, I think they're not written in our standard format.

Existing docs use '-' without any indentation for bulleted list, so I guess the current version looks good. I've added a screenshot for clarity.

image

Sorry, I was unclear. I meant the use of the paste tense, and not making them sound like instructions to the user. But you've done all that.

@simonferquel
Update changelogs for Docker Desktop edge 2.4.2.0
a13a8c4 
Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
@simonferquel
Copy link
Contributor Author

simonferquel commented Oct 15, 2020 •
edited
Loading

Updated the PR with the given feedback.
Reminding:

  • check if we updated linuxkit images <- no other linuxkit images updates (just the kernel)
  • waiting for engine bump to succeed <- done

@usha-mandya usha-mandya marked this pull request as draft October 16, 2020 09:01
@usha-mandya usha-mandya marked this pull request as ready for review October 19, 2020 08:46
@simonferquel
Fix edge release notes date
b9fad3b 
Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
@simonferquel
Copy link
Contributor Author

simonferquel commented Oct 19, 2020

Updated release date in changelog

@simonferquel
Add note about Vulnerability scanning
92bcff6 
Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
usha-mandya
usha-mandya approved these changes Oct 19, 2020
View reviewed changes
Copy link
Member

@usha-mandya usha-mandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @simonferquel

@usha-mandya usha-mandya dismissed stephen-turner’s stale review October 19, 2020 10:01

Dismissing the review to merge the PR.

@usha-mandya usha-mandya merged commit a77ca4b into docker:master Oct 19, 2020
@tnir tnir mentioned this pull request Nov 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@usha-mandya usha-mandya usha-mandya approved these changes

+2 more reviewers

@djs55 djs55 djs55 left review comments

@stephen-turner stephen-turner stephen-turner left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@simonferquel @usha-mandya @stephen-turner @djs55