-
Notifications
You must be signed in to change notification settings - Fork 8k
Add documentation for Compose service profiles #11844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Deploy preview for docsdocker ready! Built with commit fab7cf6 |
chris-crone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes but content LGTM
@usha-mandya @nebuk89 @thaJeztah How can we structure this content and where should we put it?
|
@chris-crone How about placing this above the 'Extend services in Compose" topic |
|
@usha-mandya That sounds good to me! |
|
I incorporated the change suggestions and added profiles to the navigation at the suggested place |
Adds docs for the new service profiles feature introduced in docker/compose#7930 Co-authored-by: Chris Crone <christopher.crone@docker.com>
|
Now also rebased on latest master, preview at https://deploy-preview-11844--docsdocker.netlify.app/compose/profiles/ |
chris-crone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
aiordache
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you
|
Thanks for merging! |
|
I just stumbled across this, and wondered - what does this do to compose files that are used for both compose and Swarm? |
|
@SvenDowideit AFAIK the CLI needs to be updated for |
|
TBH, the real issue is that its not addressed in the docs. |
|
@SvenDowideit this is indeed highly confusing. With Mirantis beeing now in charge for Swarm maintenance, getting it to embrace compose-spec or document divergence is challenging for documentation hosted on docker.com. I wonder how we could get Mirantis team to "own" the IMHO a possible way to manage this would be to extract |
|
I took a little time to consider my feelings on this TBH, I don't think its on Mirantis - Docker made changes to the compose spec - and the minimum change Docker should need to do, is to note (in the docs for the new profiles) that using it will cause the compose file to not work using Docker Swarm. The Next better thing, is a patch to the Swarm code to ignore this new keyword, as Swarm currently just stops. Yes, we users of Swarm realise that actual implementation is now not something we can expect from Docker - but needlessly breaking things isn't a good look. @thaJeztah what do you recon? |
|
@SvenDowideit as compose support in |

Proposed changes
This adds documentation on the new service profiles feature in
docker-composeintroduced with docker/compose#7930.Since I didn't find a good place to fit in the detailed explanation of the profiles concept this adds a new dedicated page for this.
Unreleased project version
The feature was just merged with docker/compose#7930 and is not included in a released version yet.
(But since there is no
vnext-composebranch I hope this PR against master is correct?)Related issues (optional)
docker-compose: Implement service profiles compose#7930compose-spec: Introduceprofilesfor services compose-spec/compose-spec#110compose-spec: Proposal: profiles compose-spec/compose-spec#97