-
Notifications
You must be signed in to change notification settings - Fork 8k
Adding note promoting survey #15591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Adding note promoting survey #15591
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should point to the 'Feedback' section. It currently points to another section.
Also some minor suggestion about wording: Provide feedback about Docker Compose installation instructions and enter into a lottery for Docker swag!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@usha-mandya
This was not accidental, if you use #feedback the section header will not be in view and it is confusing.
Using #feedback

If I use the previous one I see the whole "Feedback" section header and all, so this works best for users to situate themselves.
Using the previous section #

I think "this page" is shorter and is leaves it lighter (whereas comment on the instructions might seem a more involved process)and since the context is the page where the note is at the top of it does not require clarification.
Also we use that wording in the section where the survey link is available from. Are you too set on this suggestion?
If not, I would just adjust the note's case from title to sentence case.