-
Notifications
You must be signed in to change notification settings - Fork 8k
build: building images section #15618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for docsdocker ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
7839e1c to
cceace5
Compare
94d35b7 to
cd682d6
Compare
build/index.md
Outdated
| Docker Build is way more than the `docker build` command and is not only about | ||
| packaging your code, it's a whole ecosystem of tools and features that support | ||
| you not only with common workflow tasks but also provides you with support for | ||
| more complex and advanced scenarios: | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe out of scope for this PR, but I think we need more details on what BuildKit is, since the rest of our docs refer to Buildx/BuildKit freely, so we should introduce these concepts as early as possible.
At the very least, we need to clarify:
- The client (build/buildx) - server (buildkit) architecture
docker buildvsdocker buildx build- Legacy vs BuildKit
I don't think we need much space for this, but we should go over it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes in Docker Build > Overview that sgtm
_data/toc.yaml
Outdated
| section: | ||
| - path: /build/buildx/ | ||
| title: Buildx overview | ||
| title: Overview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to get rid of the Buildx section if we can, but maybe we could approach that later.
- We should merge the multiple builders page into the drivers overview, since it's too small by itself, and duplicates some of the info.
- Buildx verview page could be merged to the build overview
- Buildx install could be made to a generic build install page, where we could also cover buildkit as well later
Then drivers is left by itself, so I think we should move it to Building Images.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes we should get ride of it and move bits around.
We should merge the multiple builders page into the drivers overview, since it's too small by itself, and duplicates some of the info.
Yes that sounds good 👍
Buildx verview page could be merged to the build overview
As discussed yes good point
Buildx install could be made to a generic build install page, where we could also cover buildkit as well later
Yes some sort of Install section with Buildx, BuildKit and other tooling looks good.
Then drivers is left by itself, so I think we should move it to Building Images.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merged buildx overview to main overview page. For multiple builders, I think you can move some bits to driver guide in buildx repo.
f810587 to
e447d25
Compare
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
d6dea31 to
3f31c39
Compare
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
3f31c39 to
e25f937
Compare
jedevc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Will follow-up with the multiple builders content in buildx at some point this week 😄
This changes follow the new hierarchy proposal that has been discussed internally the past few weeks.
First phase is creating a new
Building imagessection underDocker Buildsection in manuals:Hello Buildpage has been moved toPackaging your softwareand reworkedMulti platform buildspage underBuildxsection has been moved and reworkedMulti-archpage underDesktophas been merged withMulti platform builds@jedevc I'm not sure if drivers docs should be in
Building imagessection actually. I think we can keep theBuildxsection in the meantime.