Skip to content

Conversation

@crazy-max
Copy link
Member

This changes follow the new hierarchy proposal that has been discussed internally the past few weeks.

First phase is creating a new Building images section under Docker Build section in manuals:

  • Hello Build page has been moved to Packaging your software and reworked
  • Multi platform builds page under Buildx section has been moved and reworked
  • Multi-arch page under Desktop has been merged with Multi platform builds

@jedevc I'm not sure if drivers docs should be in Building images section actually. I think we can keep the Buildx section in the meantime.

@crazy-max crazy-max requested a review from jedevc September 10, 2022 15:37
@netlify
Copy link

netlify bot commented Sep 10, 2022

Deploy Preview for docsdocker ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e25f937
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/6321ac1f14c80d0008888a1e
😎 Deploy Preview https://deploy-preview-15618--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@crazy-max crazy-max force-pushed the build-building-section branch from 7839e1c to cceace5 Compare September 10, 2022 15:41
@crazy-max crazy-max added the area/build Relates to Dockerfiles or docker build command label Sep 10, 2022
@crazy-max crazy-max force-pushed the build-building-section branch 3 times, most recently from 94d35b7 to cd682d6 Compare September 10, 2022 18:30
@crazy-max crazy-max marked this pull request as ready for review September 12, 2022 12:37
build/index.md Outdated
Comment on lines 33 to 45
Docker Build is way more than the `docker build` command and is not only about
packaging your code, it's a whole ecosystem of tools and features that support
you not only with common workflow tasks but also provides you with support for
more complex and advanced scenarios:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe out of scope for this PR, but I think we need more details on what BuildKit is, since the rest of our docs refer to Buildx/BuildKit freely, so we should introduce these concepts as early as possible.

At the very least, we need to clarify:

  • The client (build/buildx) - server (buildkit) architecture
  • docker build vs docker buildx build
  • Legacy vs BuildKit

I don't think we need much space for this, but we should go over it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes in Docker Build > Overview that sgtm

_data/toc.yaml Outdated
section:
- path: /build/buildx/
title: Buildx overview
title: Overview
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to get rid of the Buildx section if we can, but maybe we could approach that later.

  • We should merge the multiple builders page into the drivers overview, since it's too small by itself, and duplicates some of the info.
  • Buildx verview page could be merged to the build overview
  • Buildx install could be made to a generic build install page, where we could also cover buildkit as well later

Then drivers is left by itself, so I think we should move it to Building Images.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we should get ride of it and move bits around.

We should merge the multiple builders page into the drivers overview, since it's too small by itself, and duplicates some of the info.

Yes that sounds good 👍

Buildx verview page could be merged to the build overview

As discussed yes good point

Buildx install could be made to a generic build install page, where we could also cover buildkit as well later

Yes some sort of Install section with Buildx, BuildKit and other tooling looks good.

Then drivers is left by itself, so I think we should move it to Building Images.

👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged buildx overview to main overview page. For multiple builders, I think you can move some bits to driver guide in buildx repo.

@crazy-max crazy-max force-pushed the build-building-section branch from f810587 to e447d25 Compare September 13, 2022 20:22
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max crazy-max force-pushed the build-building-section branch 2 times, most recently from d6dea31 to 3f31c39 Compare September 14, 2022 09:54
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max crazy-max force-pushed the build-building-section branch from 3f31c39 to e25f937 Compare September 14, 2022 10:25
@crazy-max crazy-max requested a review from jedevc September 14, 2022 10:27
Copy link
Contributor

@jedevc jedevc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Will follow-up with the multiple builders content in buildx at some point this week 😄

@crazy-max crazy-max merged commit 525d80a into docker:master Sep 14, 2022
@crazy-max crazy-max deleted the build-building-section branch September 14, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build Relates to Dockerfiles or docker build command

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants