Move compose samples to awesome-compose repo#16001
Merged
aevesdocker merged 1 commit intodocker:mainfrom Oct 28, 2022
Merged
Conversation
StefanScherer
requested review from
aevesdocker and
usha-mandya
as code owners
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
aevesdocker
previously approved these changes
Oct 27, 2022
Contributor
aevesdocker
left a comment
aevesdocker
left a comment
There was a problem hiding this comment.
Thank you @StefanScherer!
Member
Author
|
I have to update the links to the awesome-compose repo, we're discussing to put the markdown files to a different folder there. Putting it to draft right now to make it better visible that it needs a minor change before merging. |
Signed-off-by: Stefan Scherer <stefan.scherer@docker.com>
StefanScherer
force-pushed
the
remove-compose-samples
branch
from
15eb259 to
3069987
Compare
Member
Author
|
The upstream PR got merged in awesome-compose. The external links in the preview now work fine. This PR is now ready to review. |
aevesdocker
approved these changes
Oct 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Remove the three Compose quickstart samples from docs and add them to the awesome-compose repo.
Related issues (optional)
Depends on docker/awesome-compose#305 to be merged before the hyperlinks from docs to awesome-compose actually work.
JIRA: https://docker.atlassian.net/browse/EN-293