Skip to content

Conversation

@ArnoSen
Copy link
Contributor

@ArnoSen ArnoSen commented Feb 2, 2023

Set correct filemask for /etc/apt/keyrings . If this is not 0755, the keys in the directory cannot be used.

Proposed changes

Related issues (optional)

Set correct filemask for `/etc/apt/keyrings` . If this is not 0755, the keys in the directory cannot be used.
@ArnoSen ArnoSen requested a review from dvdksn as a code owner February 2, 2023 11:24
@netlify
Copy link

netlify bot commented Feb 2, 2023

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 4cea931
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/63e25c02c574450008dd6718
😎 Deploy Preview https://deploy-preview-16654--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@craig-osterhout craig-osterhout added area/engine Issue affects Docker engine/daemon area/install Relates to installing a product labels Feb 6, 2023
@ArnoSen
Copy link
Contributor Author

ArnoSen commented Feb 7, 2023

Closes #16626
Closes #16362

@dvdksn
Copy link
Contributor

dvdksn commented Feb 7, 2023

@vvoland could you ptal? thanks

vvoland
vvoland previously approved these changes Feb 7, 2023
Copy link
Contributor

@vvoland vvoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; permissions applied by mkdir are dependent on the umask value, which in some cases may be different from 0022.

This is also conformant with Debian suggestions:

In releases older than Debian 12 and Ubuntu 22.04, /etc/apt/keyrings does not exist by default. It SHOULD be created with permissions 0755 if it is needed and does not already exist.
(source: https://wiki.debian.org/DebianRepository/UseThirdParty)

thaJeztah
thaJeztah previously approved these changes Feb 7, 2023
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but left a suggestion; we can probably merge that suggestion and squash the commits 👍

@thaJeztah thaJeztah dismissed stale reviews from vvoland and themself via 4cea931 February 7, 2023 14:11
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; I'll squash and merge 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/engine Issue affects Docker engine/daemon area/install Relates to installing a product

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants