Skip to content

Conversation

@thaJeztah
Copy link
Member

Incorporate the changes made in the debian variant from;

Signed-off-by: Sebastiaan van Stijn github@gone.nl

Proposed changes

Related issues (optional)

Incorporate the changes made in the debian variant from;

- 6d8b081
- 37ae672

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added the area/engine Issue affects Docker engine/daemon label Feb 7, 2023
@thaJeztah thaJeztah requested a review from dvdksn as a code owner February 7, 2023 14:46
@netlify
Copy link

netlify bot commented Feb 7, 2023

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit b109743
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/63e264405063fe000970fce6
😎 Deploy Preview https://deploy-preview-16681--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

`hello-world` image:

```console
$ sudo service docker start
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kept it the same as the debian variant, but wondering if we should change this to sudo systemctl start docker (as most of our docs assume systemd is used, and systemctl is likely the canonical command for that).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be safe to use systemctl, I think. Can't recall receiving any requests to update this, unlike apt/apt-get. When we get around to defining linux/unix/shell conventions, we could consider including a preference to either command there

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup; let's stick to this for now to keep them the same.

I saw some other things we could update (e.g. the examples for versions listed by apt-cache madison, and some other bits and bops).

@thaJeztah
Copy link
Member Author

Let me bring this one in 👍

@thaJeztah thaJeztah merged commit 945a042 into docker:main Feb 7, 2023
@thaJeztah thaJeztah deleted the sync_ubuntu branch February 7, 2023 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/engine Issue affects Docker engine/daemon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants