Skip to content

engine/install/ubuntu: update instructions to match debian variant #16681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2023
Merged

engine/install/ubuntu: update instructions to match debian variant #16681

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion engine/install/ubuntu.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ Docker from the repository.
2. Add Docker's official GPG key:

```console
$ sudo mkdir -p /etc/apt/keyrings
$ sudo mkdir -m 0755 -p /etc/apt/keyrings
$ curl -fsSL {{ download-url-base }}/gpg | sudo gpg --dearmor -o /etc/apt/keyrings/docker.gpg
```

Expand Down Expand Up @@ -232,6 +232,7 @@ download a new file each time you want to upgrade Docker Engine.
`hello-world` image:

```console
$ sudo service docker start
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kept it the same as the debian variant, but wondering if we should change this to sudo systemctl start docker (as most of our docs assume systemd is used, and systemctl is likely the canonical command for that).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be safe to use systemctl, I think. Can't recall receiving any requests to update this, unlike apt/apt-get. When we get around to defining linux/unix/shell conventions, we could consider including a preference to either command there

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup; let's stick to this for now to keep them the same.

I saw some other things we could update (e.g. the examples for versions listed by apt-cache madison, and some other bits and bops).

$ sudo docker run hello-world
```

Expand Down