Updating the Oracle Linux installation documentation#1922
Merged
mdlinville merged 3 commits intodocker:masterfrom Feb 22, 2017
Djelibeybi:oraclelinux-docs
Merged
Updating the Oracle Linux installation documentation#1922mdlinville merged 3 commits intodocker:masterfrom Djelibeybi:oraclelinux-docs
mdlinville merged 3 commits intodocker:masterfrom
Djelibeybi:oraclelinux-docs
Conversation
* Change the note about the UEK4, because it's not only required for `btrfs` support * Added a note about the fact that Oracle also ships a supported package with the same name as upstream * Added a note about the fact that we've already deprecated docker-engine-selinux * Added a link to the Oracle Linux Docker User's Guide * Fixed the GPG key section as it will not be shown during the `makecache fast` run but rather will automatically be accepted when the yum install command is run. * Added a note about disabling the `-y` parameter to prevent the automatic acceptance of the upstream GPG key * Provided the specific GPG key output for better validation * Provide context about the fact that `docker-engine` exists in the Oracle Linux addons repo as well and may appear in the results of the `yum ilst` command. * Provide more context for the `btrfs` subvolume removal
The default RHCK (3.10) does not support overlay2.
Signed-off-by: Avi Miller <avi.miller@gmail.com>
mdlinville
approved these changes
Feb 22, 2017
mdlinville
left a comment
mdlinville
left a comment
There was a problem hiding this comment.
Thanks for the additional feedback and for your diligence!
friism
reviewed
Feb 22, 2017
| You can install Docker in different ways, depending on your needs: | ||
|
|
||
| - Most users | ||
| - Users who do not require Docker support from Oracle |
Contributor
There was a problem hiding this comment.
I think this is missing a "can"
There was a problem hiding this comment.
I'll fix that in follow-up. Thanks @friism
Contributor
Author
There was a problem hiding this comment.
I left it in the active voice, i.e. "these users do this" as opposed to "these users could do this". But you could add "can" back into this sentence as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Following from #1567, this PR includes updates incorporated after receiving feedback from the Docker team.
Related issues (optional)
#1567