releaser: fix error with too many (redirect) args to jq #21353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
github-actions
bot
added
area/release
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
crazy-max
reviewed
Nov 6, 2024
Member
There was a problem hiding this comment.
Can you also print
Line 237 in 00b5254
Edit: We don't run releaser on PR but we could have a dry-run mode for it I think.
dvdksn
force-pushed
the
fix-releaser-etoomanyredirects-take2
branch
from
55d170a to
b27dd74
Compare
dvdksn
force-pushed
the
fix-releaser-etoomanyredirects-take2
branch
2 times, most recently
from
b0e7443 to
f8de4cd
Compare
Contributor
Author
|
@crazy-max I added a dumb dry-run mode, and I reverted back to using Output of cloudfront config with `DRY_RUN=1` |
thaJeztah
reviewed
Nov 6, 2024
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
dvdksn
force-pushed
the
fix-releaser-etoomanyredirects-take2
branch
from
f8de4cd to
9ee4e85
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
fix-releaser-etoomanyredirects-take2
branch
from
50ba277 to
db6966c
Compare
crazy-max
approved these changes
Nov 7, 2024
Member
crazy-max
left a comment
crazy-max
left a comment
There was a problem hiding this comment.
Pushed extra commit to check cloudfront config in dry run and looks good: https://github.com/docker/docs/actions/runs/11719640810/job/32643351302#step:5:362
As follow-up we could output the lambda zip function and validate it on PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's not break the site this time