Skip to content

Conversation

@dvdksn
Copy link
Contributor

@dvdksn dvdksn commented Nov 8, 2024

Follow-up to #21377

I noticed that we have hard-coded the "current" and "previous" API versions in an example here, so changing it to a dynamic value (latest, latest - 1) to avoid having to update this part every time we release a new engine API version. We still need to update code blocks manually but at least this is one thing less.

Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
@dvdksn dvdksn requested a review from thaJeztah November 8, 2024 11:06
@github-actions github-actions bot added area/engine Issue affects Docker engine/daemon area/api Relates to Docker API docs labels Nov 8, 2024
@netlify
Copy link

netlify bot commented Nov 8, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 473a19c
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/672df0bc9713af0008088e9b
😎 Deploy Preview https://deploy-preview-21379--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thaJeztah
Copy link
Member

LOL; would we have some way to make vale understand {{%... %}} ?

Screenshot 2024-11-09 at 00 18 06

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice!

@thaJeztah thaJeztah merged commit 16c86ec into docker:main Nov 8, 2024
14 checks passed
@dvdksn dvdksn deleted the dynamic-api-version-example branch November 9, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/api Relates to Docker API docs area/engine Issue affects Docker engine/daemon status/review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants