ENGDOCS-2305 #21397
Merged
ENGDOCS-2305 #21397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
content/manuals/security/for-admins/hardened-desktop/settings-management/_index.md
Outdated
Show resolved
Hide resolved
content/manuals/security/for-admins/hardened-desktop/settings-management/_index.md
Outdated
Show resolved
Hide resolved
content/manuals/security/for-admins/hardened-desktop/settings-management/_index.md
Outdated
Show resolved
Hide resolved
content/manuals/security/for-admins/hardened-desktop/settings-management/_index.md
Outdated
Show resolved
Hide resolved
content/manuals/security/for-admins/hardened-desktop/settings-management/_index.md
Outdated
Show resolved
Hide resolved
content/manuals/security/for-admins/hardened-desktop/settings-management/configure.md
Outdated
Show resolved
Hide resolved
content/manuals/security/for-admins/hardened-desktop/settings-management/configure.md
Outdated
Show resolved
Hide resolved
sarahsanders-docker
previously requested changes
Nov 12, 2024
Contributor
sarahsanders-docker
left a comment
sarahsanders-docker
left a comment
There was a problem hiding this comment.
overall looks good! I left a few small nits and suggestions
Co-authored-by: Sarah Sanders <sarah.sanders@docker.com>
aevesdocker
dismissed
sarahsanders-docker’s stale review
Suggestion absorbed
Contributor
Author
|
Thank you for the thorough review @sarahsanders-docker 🙌 |
dvdksn
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Settings Management freshness before the arrival of the SM in the Admin Console. Have grouped the settings as they appear in the AC.
Page is still quite long and so would like to do some testing (potench before the year is out) on whether splitting the info on all the settings into its own 'reference' page would be useful or too 'jumpy' for users.
Related issues or tickets
Reviews