Skip to content

Change Docker image in part8 of getting started #21424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 14, 2024
Merged

Change Docker image in part8 of getting started #21424

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
03507ba
Update 09_image_best.md - 18-alpine image
mjbear Nov 11, 2024
0834e18
Merge branch 'docker:main' into getting-started_part8_image
mjbear Nov 14, 2024
b04982b
Replace node:18 with node:lts in 09_image_best.md
mjbear Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions content/get-started/workshop/09_image_best.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ Look at the following Dockerfile you created for the getting started app.

```dockerfile
# syntax=docker/dockerfile:1
FROM node:18-alpine
FROM node:lts-alpine
WORKDIR /app
COPY . .
RUN yarn install --production
Expand All @@ -81,7 +81,7 @@ dependencies if there was a change to the `package.json`.

```dockerfile
# syntax=docker/dockerfile:1
FROM node:18-alpine
FROM node:lts-alpine
WORKDIR /app
COPY package.json yarn.lock ./
RUN yarn install --production
Expand All @@ -103,10 +103,10 @@ dependencies if there was a change to the `package.json`.
=> => transferring dockerfile: 175B
=> [internal] load .dockerignore
=> => transferring context: 2B
=> [internal] load metadata for docker.io/library/node:18-alpine
=> [internal] load metadata for docker.io/library/node:lts-alpine
=> [internal] load build context
=> => transferring context: 53.37MB
=> [1/5] FROM docker.io/library/node:18-alpine
=> [1/5] FROM docker.io/library/node:lts-alpine
=> CACHED [2/5] WORKDIR /app
=> [3/5] COPY package.json yarn.lock ./
=> [4/5] RUN yarn install --production
Expand All @@ -127,10 +127,10 @@ dependencies if there was a change to the `package.json`.
=> => transferring dockerfile: 37B
=> [internal] load .dockerignore
=> => transferring context: 2B
=> [internal] load metadata for docker.io/library/node:18-alpine
=> [internal] load metadata for docker.io/library/node:lts-alpine
=> [internal] load build context
=> => transferring context: 450.43kB
=> [1/5] FROM docker.io/library/node:18-alpine
=> [1/5] FROM docker.io/library/node:lts-alpine
=> CACHED [2/5] WORKDIR /app
=> CACHED [3/5] COPY package.json yarn.lock ./
=> CACHED [4/5] RUN yarn install --production
Expand Down Expand Up @@ -182,7 +182,7 @@ for your production build. You can ship the static resources in a static nginx c

```dockerfile
# syntax=docker/dockerfile:1
FROM node:18 AS build
FROM node:lts AS build
WORKDIR /app
COPY package* yarn.lock ./
RUN yarn install
Expand All @@ -194,7 +194,7 @@ FROM nginx:alpine
COPY --from=build /app/build /usr/share/nginx/html
```

In the previous Dockerfile example, it uses the `node:18` image to perform the build (maximizing layer caching) and then copies the output
In the previous Dockerfile example, it uses the `node:lts` image to perform the build (maximizing layer caching) and then copies the output
into an nginx container.

## Summary
Expand Down