ENGDOCS-2342 #21573
Merged
ENGDOCS-2342 #21573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/desktop
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Xeeynamo
reviewed
Dec 6, 2024
Contributor
Xeeynamo
left a comment
Xeeynamo
left a comment
There was a problem hiding this comment.
Thanks for taking care of documenting the desktop CLI commands. There are a few other options that needs to be added. But overall it looks good!
Xeeynamo
reviewed
Dec 11, 2024
Contributor
Xeeynamo
left a comment
Xeeynamo
left a comment
There was a problem hiding this comment.
Leaving a few more comments on top of changes I did not notice on the first round of reviews
Comment on lines
28
to
29
| value_type: string | ||
| default_value: '[]' |
Contributor
There was a problem hiding this comment.
Suggested change
| value_type: string | |
| default_value: '[]' | |
| value_type: int | |
| default_value: 0 |
Comment on lines
18
to
19
| value_type: stringArray | ||
| default_value: '[]' |
Contributor
There was a problem hiding this comment.
Suggested change
| value_type: stringArray | |
| default_value: '[]' | |
| value_type: bool | |
| default_value: false |
Comment on lines
27
to
28
| value_type: string | ||
| default_value: '[]' |
Contributor
There was a problem hiding this comment.
Suggested change
| value_type: string | |
| default_value: '[]' | |
| value_type: int | |
| default_value: 0 |
Comment on lines
18
to
19
| value_type: stringArray | ||
| default_value: '[]' |
Contributor
There was a problem hiding this comment.
Suggested change
| value_type: stringArray | |
| default_value: '[]' | |
| value_type: bool | |
| default_value: false |
Xeeynamo
approved these changes
Dec 11, 2024
dvdksn
reviewed
Dec 12, 2024
|
|
||
| The Docker Desktop CLI provides: | ||
|
|
||
| - Enhanced automation and CI/CD integration: Perform Docker Desktop operations directly in CI/CD pipelines for better workflow automation. |
Contributor
There was a problem hiding this comment.
Who in their right mind would use Docker Desktop in CI?
dvdksn
previously approved these changes
Dec 12, 2024
aevesdocker
added a commit
to aevesdocker/docs
that referenced
this pull request
Dec 12, 2024
<!--Delete sections as needed --> ## Description New DD CLI feature for 4.37. Followed the way docker debug was added to the CLI reference ## Related issues or tickets <!-- Related issues, pull requests, or Jira tickets --> ## Reviews <!-- Notes for reviewers here --> <!-- List applicable reviews (optionally @tag reviewers) --> - [ ] Technical review - [ ] Editorial review - [ ] Product review
sarahsanders-docker
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New DD CLI feature for 4.37. Followed the way docker debug was added to the CLI reference
Related issues or tickets
Reviews