harmonia: one more pass for bind volumes #21582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nicksieger
approved these changes
Dec 6, 2024
rodnymolina
approved these changes
Dec 6, 2024
content/manuals/harmonia/_index.md
Outdated
| - Containers cannot access host through DNS `host.docker.internal`. | ||
| - File binds (non-directory binds) are currently static, meaning changes will not be reflected until the container is restarted. This also affects Compose configs and secrets directives. | ||
| - Bind mounts, such as `-v /localpath:/incontainer` in the `docker run` command, are not supported without using a file-sync. | ||
| - Bind _mounts_, such as `-v /localpath:/incontainer` in the `docker run` command, require starting a file-sync. |
Co-authored-by: Nick Sieger <nicksieger@gmail.com>
stevvooe
commented
Dec 7, 2024
dvdksn
reviewed
Dec 9, 2024
| - Bind mounts, such as `-v /localpath:/incontainer` in the `docker run` command, are not supported without using a file-sync. | ||
| - Bind _mounts_, such as `-v /localpath:/incontainer` in the `docker run` command, require creating a file-sync. | ||
| - Starting a file-sync for a directory with a large amount of may take extra time to sync and become ready for use in a container. | ||
| - Bind _volumes_, such as those created with `docker volume create --driver local --opt type=none --opt o=bind --opt device=/some/host/path myvolname` or via the compose equivalent, are not supported. |
Contributor
There was a problem hiding this comment.
nit: local is the default driver, so can be omitted in this example for brevity.
Suggested change
| - Bind _volumes_, such as those created with `docker volume create --driver local --opt type=none --opt o=bind --opt device=/some/host/path myvolname` or via the compose equivalent, are not supported. | |
| - Bind _volumes_, such as those created with `docker volume create --opt type=none --opt o=bind --opt device=/some/host/path myvolname` or via the compose equivalent, are not supported. |
Contributor
Author
There was a problem hiding this comment.
I actually left this in so the context would be clear. Feel free to commit suggestion if you think its not necessary.
Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
dvdksn
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After some discussion with the team, we've added a few more conditions.
Related issues or tickets
Reviews