build: update gc documentation #21617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/build
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dvdksn
commented
Dec 12, 2024
| If you're using the [`docker` driver](../builders/drivers/docker.md), garbage collection | ||
| can be configured in the [Docker Daemon configuration](/reference/cli/dockerd.md#daemon-configuration-file). | ||
| file: | ||
| 1. Remove ephemeral, unused build cache older than 48 hours if it exceeds 10% |
Contributor
Author
There was a problem hiding this comment.
🙃
Suggested change
| 1. Remove ephemeral, unused build cache older than 48 hours if it exceeds 10% | |
| 1. Remove ephemeral, unused build cache older than 48 hours if it exceeds 13.8% |
Member
There was a problem hiding this comment.
We should align moby with buildkit, doesn't make sense to have a different default GC policy. Moby could probably just call https://github.com/moby/buildkit/blob/f2092259de4a7fbdb05c84b1c8791c9a3ca578c4/cmd/buildkitd/config/gcpolicy.go#L71 and remove https://github.com/moby/moby/blob/d60e55d613a35a11d59310a1ec16eb06f2133eb1/builder/builder-next/worker/gc.go#L18
Contributor
There was a problem hiding this comment.
// tempCachePercent represents the percentage ratio of the cache size in bytes to temporarily keep for a short period of time (couple of days)
// over the total cache size in bytes. Because there is no perfect value, a mathematically pleasing one was chosen.
// The value is approximately 13.8
const tempCachePercent = math.E * math.Pi * math.Philol
tonistiigi
reviewed
Dec 12, 2024
| } | ||
| ``` | ||
|
|
||
| The `defaultKeepStorage` option configures the size limit of the build cache, |
Member
There was a problem hiding this comment.
From BuildKit v0.17 and moby/moby#48720 these defaults are different with reserved,free,max all being configured by default.
dvdksn
force-pushed
the
build-gcconfig
branch
from
2911e0b to
87a4be8
Compare
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
dvdksn
force-pushed
the
build-gcconfig
branch
from
87a4be8 to
841ca61
Compare
crazy-max
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revise the documentation for build GC and configuring GC policies.
Also updates the configuration to describe the new GC config options.
Preview: https://deploy-preview-21617--docsdocker.netlify.app/build/cache/garbage-collection/
Related issues