Skip to content

Conversation

@PMR745
Copy link
Contributor

@PMR745 PMR745 commented Jan 6, 2025

Description

Added a step in the VS Code section of the "Build and Push Your First Image" guide to install the Docker extension. This ensures that users have all the necessary tools configured, improving the onboarding experience for beginners.

Related issues or tickets

Fixes Missing Docker Extension Installation Step #21720

Location

https://docs.docker.com/get-started/introduction/build-and-push-first-image/

Reviews

Notes for reviewers:

  • Verify the new step in the VS Code section accurately explains how to install the Docker extension.
  • Confirm the changes align with the current structure and tone of the documentation.

Applicable reviews:

  • Technical review
  • Editorial review
  • Product review

Output

Screenshot 2025-01-06 at 12 09 14 PM

@github-actions github-actions bot added the area/get-started Relates to get started and onboarding docs label Jan 6, 2025
@netlify
Copy link

netlify bot commented Jan 6, 2025

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 41e2d0c
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/677fcc59404ab40008b9a5e2
😎 Deploy Preview https://deploy-preview-21722--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🎉 very nice addition!

Only thing I would like to see here is that we compress the image size. https://squoosh.app/ is a great tool for this. I usually use OxiPNG with reduced palette:

image

@PMR745 PMR745 requested a review from dvdksn January 6, 2025 08:59
Copy link
Contributor

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm 🤔 it looks like we have a bit of screenshot inception going on. The screenshot embedded on the docs page now appears to show a snapshot of the docs page itself 😅

image

Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
@dvdksn dvdksn force-pushed the feat/vscode_extension branch from a397cb1 to 41e2d0c Compare January 9, 2025 13:17
Copy link
Contributor

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated with the original (compressed) screenshot and squashed the commits. Thanks for the contribution 🎉

@dvdksn dvdksn merged commit 5526949 into docker:main Jan 9, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/get-started Relates to get started and onboarding docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing Docker Extension Installation Step

2 participants