Skip to content

Conversation

@vvoland
Copy link
Contributor

@vvoland vvoland commented Jan 22, 2025

Description

Related issues or tickets

Reviews

  • Technical review
  • Editorial review
  • Product review

@github-actions github-actions bot added the area/engine Issue affects Docker engine/daemon label Jan 22, 2025
@netlify
Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 525d991
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/67913399d9ef470008b60e32
😎 Deploy Preview https://deploy-preview-21869--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@robmry robmry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

### Bug fixes and enhancements

- Fixed an issue that could persistently prevent daemon startup after failure to initialize the default bridge. [moby/moby#49307](https://github.com/moby/moby/pull/49307)
- On a host that cannot load the `br_netfilter` module when it's needed, set environment variable `DOCKER_IGNORE_BR_NETFILTER_ERROR=1` to ignore the problem. Some things won't work! Including disabling inter-container communication in a bridge network and, with the userland proxy disabled, it won't be possible to access one container's published ports from another container on the same network. [moby/moby#49306](https://github.com/moby/moby/pull/49306)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like vale doesn't like the exclamation mark (!) here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we could change this to be more active voiced, and something like "Add a DOCKER_IGNORE_BR_NETFILTER_ERROR=1 to allow running on hosts that cannot load br_netfilter", but keeping some warning after that to make sure it's clear that it's not a good setup.

cc @dvdksn @robmry in case you have suggestions

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good ... I think they were my words from the PR, and my voice is generally about as active as the rest of me!

thaJeztah
thaJeztah previously approved these changes Jan 22, 2025
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me pre-LGTM in case we want to merge (we can still fix up things)

@vvoland vvoland marked this pull request as ready for review January 22, 2025 17:36
@vvoland vvoland requested a review from dvdksn as a code owner January 22, 2025 17:36
### Bug fixes and enhancements

- Fix an issue that could persistently prevent daemon startup after failure to initialize the default bridge. [moby/moby#49307](https://github.com/moby/moby/pull/49307)
- Add a `DOCKER_IGNORE_BR_NETFILTER_ERROR` environment variable to allow running on hosts that cannot load `br_netfilter`. [moby/moby#49306](https://github.com/moby/moby/pull/49306)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry @vvoland ... I think we need to keep the warning. This escape hatch is quite dangerous!

Suggested change
- Add a `DOCKER_IGNORE_BR_NETFILTER_ERROR` environment variable to allow running on hosts that cannot load `br_netfilter`. [moby/moby#49306](https://github.com/moby/moby/pull/49306)
- Add a `DOCKER_IGNORE_BR_NETFILTER_ERROR` environment variable to allow running on hosts that cannot load `br_netfilter`. Some things won't work, including disabling inter-container communication in a bridge network. With the userland proxy disabled, it won't be possible to access one container's published ports from another container on the same network. [moby/moby#49306](https://github.com/moby/moby/pull/49306)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTY now?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does, thank you!

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah thaJeztah merged commit dd14a64 into docker:main Jan 22, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/engine Issue affects Docker engine/daemon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants