-
Notifications
You must be signed in to change notification settings - Fork 8.1k
engine: 27.5.1 release notes #21869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
engine: 27.5.1 release notes #21869
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
3cec8bc to
7065fa4
Compare
robmry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| ### Bug fixes and enhancements | ||
|
|
||
| - Fixed an issue that could persistently prevent daemon startup after failure to initialize the default bridge. [moby/moby#49307](https://github.com/moby/moby/pull/49307) | ||
| - On a host that cannot load the `br_netfilter` module when it's needed, set environment variable `DOCKER_IGNORE_BR_NETFILTER_ERROR=1` to ignore the problem. Some things won't work! Including disabling inter-container communication in a bridge network and, with the userland proxy disabled, it won't be possible to access one container's published ports from another container on the same network. [moby/moby#49306](https://github.com/moby/moby/pull/49306) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like vale doesn't like the exclamation mark (!) here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we could change this to be more active voiced, and something like "Add a DOCKER_IGNORE_BR_NETFILTER_ERROR=1 to allow running on hosts that cannot load br_netfilter", but keeping some warning after that to make sure it's clear that it's not a good setup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good ... I think they were my words from the PR, and my voice is generally about as active as the rest of me!
thaJeztah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let me pre-LGTM in case we want to merge (we can still fix up things)
7065fa4 to
fdc9a65
Compare
| ### Bug fixes and enhancements | ||
|
|
||
| - Fix an issue that could persistently prevent daemon startup after failure to initialize the default bridge. [moby/moby#49307](https://github.com/moby/moby/pull/49307) | ||
| - Add a `DOCKER_IGNORE_BR_NETFILTER_ERROR` environment variable to allow running on hosts that cannot load `br_netfilter`. [moby/moby#49306](https://github.com/moby/moby/pull/49306) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, sorry @vvoland ... I think we need to keep the warning. This escape hatch is quite dangerous!
| - Add a `DOCKER_IGNORE_BR_NETFILTER_ERROR` environment variable to allow running on hosts that cannot load `br_netfilter`. [moby/moby#49306](https://github.com/moby/moby/pull/49306) | |
| - Add a `DOCKER_IGNORE_BR_NETFILTER_ERROR` environment variable to allow running on hosts that cannot load `br_netfilter`. Some things won't work, including disabling inter-container communication in a bridge network. With the userland proxy disabled, it won't be possible to access one container's published ports from another container on the same network. [moby/moby#49306](https://github.com/moby/moby/pull/49306) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTY now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does, thank you!
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
fdc9a65 to
525d991
Compare
thaJeztah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Description
Related issues or tickets
Reviews