Improve security documentation with warning around windows containers #21929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/desktop
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Some background dialog between security, desktop, moby teams and some security researchers. At the present time, this is an accepted risk in Docker Desktop installations for Windows and should be clarified in better detail.
aevesdocker
reviewed
Jan 30, 2025
Contributor
aevesdocker
left a comment
aevesdocker
left a comment
There was a problem hiding this comment.
Thanks @twelsh-aw. Just some style guide and formatting nits
content/manuals/desktop/setup/install/windows-permission-requirements.md
Outdated
Show resolved
Hide resolved
content/manuals/desktop/setup/install/windows-permission-requirements.md
Outdated
Show resolved
Hide resolved
content/manuals/desktop/setup/install/windows-permission-requirements.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Allie Sadler <102604716+aevesdocker@users.noreply.github.com>
Co-authored-by: Allie Sadler <102604716+aevesdocker@users.noreply.github.com>
Co-authored-by: Allie Sadler <102604716+aevesdocker@users.noreply.github.com>
Co-authored-by: Allie Sadler <102604716+aevesdocker@users.noreply.github.com>
| - `--quiet`: Suppresses information output when running the installer | ||
| - `--accept-license`: Accepts the [Docker Subscription Service Agreement](https://www.docker.com/legal/docker-subscription-service-agreement) now, rather than requiring it to be accepted when the application is first run | ||
| - `--no-windows-containers`: Disables the Windows containers integration | ||
| - `--no-windows-containers`: Disables the Windows containers integration. This can have security implication. For more information, see [Windows containers](/manuals/desktop/setup/install/windows-permission-requirements.md#windows-containers). |
Contributor
There was a problem hiding this comment.
This phrasing makes it a bit unclear that not having it is the less secure thing. Maybe we should rephrase but not sure what's the best wording
Contributor
There was a problem hiding this comment.
Maybe 'This can improve security'?
Contributor
Author
There was a problem hiding this comment.
Agreed. That seems clearer. Will go with 'This can improve security.'
Longer term, we do have plans to tweak these options and make the secure option is the default behaviour. So this is all interim text anyways.
gabriellavengeo
approved these changes
Jan 30, 2025
aevesdocker
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some background dialog between security, desktop, moby teams and some security researchers. At the present time, this is an accepted risk in Docker Desktop installations for Windows and should be clarified in better detail.
Related issues or tickets
PSEC-1839
Reviews