Skip to content

ECI and Kubernetes Improvements #21961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 4, 2025
Merged

ECI and Kubernetes Improvements #21961

merged 3 commits into from
Feb 4, 2025

Conversation

@ctalledo
Copy link
Contributor

@ctalledo ctalledo commented Feb 4, 2025 •
edited
Loading

Description

  • Added an image in the "Deploy on Kubernetes" section showing the Docker Desktop Kubernetes settings.
  • Updated the ECI FAQs regarding ECI protection for docker build and Kubernetes.

Reviews

  • Technical review
  • Editorial review
  • Product review

@ctalledo
Add picture to Deploy Kubernetes docs.
3e0ca83 
A picture says a thousand words, so show our users how
the Docker Desktop kubernetes settings look like.

Signed-off-by: Cesar Talledo <cesar.talledo@docker.com>
@ctalledo ctalledo requested a review from aevesdocker as a code owner February 4, 2025 03:14
@github-actions github-actions bot added area/desktop Issue affects a desktop edition of Docker. E.g docker for mac area/security labels Feb 4, 2025
@netlify
Copy link

netlify bot commented Feb 4, 2025 •
edited
Loading

✅ Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 85c6fab
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/67a1e54919027400083b40e7
😎 Deploy Preview https://deploy-preview-21961--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ctalledo
Clarify ECI protection for docker build and Kubernetes.
7b06a21 
Signed-off-by: Cesar Talledo <cesar.talledo@docker.com>
aevesdocker
aevesdocker reviewed Feb 4, 2025
View reviewed changes
aevesdocker
aevesdocker approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@aevesdocker aevesdocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ctalledo

@aevesdocker aevesdocker merged commit cb21bfc into docker:main Feb 4, 2025
14 checks passed
@ctalledo
Copy link
Contributor Author

ctalledo commented Feb 4, 2025

Thanks @aevesdocker for the quick review and improvements!

@ctalledo ctalledo deleted the eci-k8s branch February 4, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aevesdocker aevesdocker aevesdocker approved these changes

Assignees

No one assigned

Labels

area/desktop Issue affects a desktop edition of Docker. E.g docker for mac area/security

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ctalledo @aevesdocker