Fix make vendor
#22437
Merged
Fix make vendor
#22437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the golang image to one that uses the Go 1.23.8. 1.23-alpine3.21 is still on go 1.23.7 and current `go.mod` requires go1.23.8 which makes the `make vendor` fail with: ``` 0.117 go: go.mod requires go >= 1.23.8 (running go 1.23.7; GOTOOLCHAIN=local) 0.119 Error: failed to get ["github.com/docker/cli@v28.1.0-rc.1"]: failed to execute 'go [get github.com/docker/cli@v28.1.0-rc.1]': failed to execute binary "go" with args [get github.com/docker/cli@v28.1.0-rc.1]: go: go.mod requires go >= 1.23.8 (running go 1.23.7; GOTOOLCHAIN=local) 0.119 *errors.errorString ``` Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
aevesdocker
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the golang image to one that uses the Go 1.23.8.
1.23-alpine3.21 is still on go 1.23.7 and current
go.modrequires go1.23.8 which makes themake vendorfail with:Description
Related issues or tickets
Reviews