engine: v28.1.0 #22438
Merged
engine: v28.1.0 #22438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/engine
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
vvoland
force-pushed
the
28.1.0
branch
3 times, most recently
from
70f7753 to
5bd4998
Compare
Contributor
Author
|
@aevesdocker PTAL |
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
full diff: moby/moby@v28.0.2...v28.1.0-rc.2 Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
full diff: docker/cli@v28.0.4...v28.1.0-rc.2 Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
aevesdocker
reviewed
Apr 17, 2025
aevesdocker
previously approved these changes
Apr 17, 2025
Contributor
aevesdocker
left a comment
aevesdocker
left a comment
There was a problem hiding this comment.
Thank you @vvoland! LGTM
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
aevesdocker
reviewed
Apr 17, 2025
| - Fix a regression causing `docker pull/push` to fail when interacting with a private repository. [docker/cli#5964](https://github.com/docker/cli/pull/5964) | ||
| - Fix an issue preventing rootless Docker setup on a host with no `ip_tables` kernel module. [moby/moby#49727](https://github.com/moby/moby/pull/49727) | ||
| - Fix an issue that could lead to unwanted iptables rules being restored and never deleted following a firewalld reload. [moby/moby#49728](https://github.com/moby/moby/pull/49728) | ||
| - Fix login hints when logging into a custom registry. [docker/cli#6015](https://github.com/docker/cli/pull/6015) |
Contributor
There was a problem hiding this comment.
Suggested change
| - Fix login hints when logging into a custom registry. [docker/cli#6015](https://github.com/docker/cli/pull/6015) | |
| - Fix sign-in hints when signing in to a custom registry. [docker/cli#6015](https://github.com/docker/cli/pull/6015) |
Contributor
Author
There was a problem hiding this comment.
In this case it's during docker login, so perhaps the login term makes more sense here?
aevesdocker
previously approved these changes
Apr 17, 2025
usha-mandya
reviewed
Apr 17, 2025
Address a review comment
usha-mandya
requested review from
sarahsanders-docker and
thaJeztah
as code owners
thaJeztah
reviewed
Apr 17, 2025
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
Thanks! Overall looks good; left a couple of suggestions; I updated the related PRs for that as well.
Some things to do (in a follow-up);
- Update the "install" section to include the new distros
- (And we probably need to remove some that reached EOL, or will soon reach EOL)
| # github.com/moby/buildkit v0.21.0 | ||
| # github.com/docker/buildx v0.23.0 | ||
| # github.com/docker/cli v28.0.4+incompatible | ||
| # github.com/docker/cli v28.1.0-rc.2+incompatible |
Member
There was a problem hiding this comment.
These probably need a final revendor after it's tagged.
| - Add Debian "Trixie" packages. [docker/docker-ce-packaging#1181](https://github.com/docker/docker-ce-packaging/pull/1181) | ||
| - Add Fedora 42 packages. [docker/containerd-packaging#418](https://github.com/docker/containerd-packaging/pull/418), [docker/docker-ce-packaging#1169](https://github.com/docker/docker-ce-packaging/pull/1169) | ||
| - Add Ubuntu "Plucky Puffin" packages. [docker/containerd-packaging#419](https://github.com/docker/containerd-packaging/pull/419), [docker/docker-ce-packaging#1177](https://github.com/docker/docker-ce-packaging/pull/1177) | ||
| - Update BuildKit to [v0.21.0](https://github.com/moby/buildkit/releases/tag/v0.21.0). [moby/moby#49809](https://github.com/moby/moby/pull/49809) |
Member
There was a problem hiding this comment.
I don't think we did so before, but we should at some point consider to also mention the Dockerfile syntax version we updated to (as it also had some updates).
Contributor
Author
There was a problem hiding this comment.
Not sure - it's a part of BuildKit and we link to BuildKit release notes which mention it.
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Contributor
Author
|
Updated with Sebastiaan suggestions (thanks for editing the PRs directly!) |
usha-mandya
approved these changes
Apr 17, 2025
Member
usha-mandya
left a comment
usha-mandya
left a comment
There was a problem hiding this comment.
LGTM. @thaJeztah Will do a follow-up PR for the install section updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues or tickets
Reviews