Skip to content

Conversation

@crazy-max
Copy link
Member

@crazy-max crazy-max commented May 13, 2025

Description

Update go to 1.24. Also removes toolchain directive that should not be used as we are doing sandboxed builds.

Related issues or tickets

Reviews

  • Technical review
  • Editorial review
  • Product review

Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@netlify
Copy link

netlify bot commented May 13, 2025

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 4084a45
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/682346487b52830008e19d4a
😎 Deploy Preview https://deploy-preview-22629--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added area/release Relates to CI or deployment hugo Updates related to hugo dependencies Vendoring, packaging updates area/config labels May 13, 2025
@crazy-max crazy-max requested a review from thaJeztah May 14, 2025 10:36
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

One thing I recently learned (or perhaps knew, but forgot about) was that go-setup-action does NOT set "go toolchain" to "local", so regardless what version you ask it to install, it may still download a different version when running 🫠 🫠 🫠

@thaJeztah thaJeztah merged commit 1728f29 into docker:main May 14, 2025
14 checks passed
@crazy-max
Copy link
Member Author

One thing I recently learned (or perhaps knew, but forgot about) was that go-setup-action does NOT set "go toolchain" to "local", so regardless what version you ask it to install, it may still download a different version when running 🫠 🫠 🫠

Ah good to know!

@crazy-max crazy-max deleted the bump-go branch May 14, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config area/release Relates to CI or deployment dependencies Vendoring, packaging updates hugo Updates related to hugo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants